Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix: height issues with webframe #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrettJephson merged 13 commits into main from webframe-height-issue
Oct 24, 2025
Merged

Fix: height issues with webframe #3749

BrettJephson merged 13 commits into main from webframe-height-issue
Oct 24, 2025

Conversation

@BrettJephson
Copy link
Contributor

@BrettJephson BrettJephson commented Oct 23, 2025 •
edited
Loading

Updates algorithm for sizing webframe to fix two issues:

  1. webframe adding extra space under Mermaid diagrams
  2. webframe cutting off content in integration form.

Added another Mermaid diagram to e2e tests to test landscape.

Tested with:
https://gitbook-v2-q3lwp8faq-gitbook.vercel.app/url/mariadb.com/docs/mariadb-cloud#mariadb-cloud-autonomous-resilient-end-to-end-secure (mermaid diagram)
https://gitbook-v2-q3lwp8faq-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open/blocks/integrations (mermaid diagram)
https://gitbook-v2-q3lwp8faq-gitbook.vercel.app/url/payments.govstack.global/10-workflows (mermaid diagrams)
https://gitbook-v2-q3lwp8faq-gitbook.vercel.app/url/mariadb.com/docs/platform/post-download/mariadb-server-12.0.2 (marketo form)

Copy link

changeset-bot bot commented Oct 23, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 049327c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BrettJephson BrettJephson changed the title (削除) height (削除ここまで) (追記) Fix: height issues with webframe (追記ここまで) Oct 23, 2025
Copy link

argos-ci bot commented Oct 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 1 changed Oct 24, 2025, 9:22 AM
v2-cloudflare (Inspect) 👍 Changes approved 4 added Oct 24, 2025, 9:26 AM
v2-vercel (Inspect) 👍 Changes approved 9 changed, 4 added Oct 24, 2025, 9:25 AM

Copy link
Member

@clairechabas clairechabas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the height calculation when the iframe content is a form but it regresses back to the original bug on the height calculation for diagrams which have a large width and a small height.

I approve because the bug on the form iframe is more impactful than the one on the diagrams height so if we can't figure out a good fix for both we should fix the first one in priority and tackle the other separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clairechabas clairechabas clairechabas approved these changes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /