Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update Node version to work with globalThis.process.getBuiltinModule #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrettJephson merged 3 commits into main from update-nvmrc
Oct 14, 2025

Conversation

@BrettJephson
Copy link
Contributor

@BrettJephson BrettJephson commented Oct 14, 2025
edited
Loading

bun dev wasn’t working with Node version 20.6, threw an error because of globalThis.process.getBuiltinModule, which is supported in v20.16.

Copy link

changeset-bot bot commented Oct 14, 2025
edited
Loading

🦋 Changeset detected

Latest commit: 3573b59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

argos-ci bot commented Oct 14, 2025
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) 👍 Changes approved 2 changed Oct 14, 2025, 10:08 AM
v2-cloudflare (Inspect) 👍 Changes approved 13 changed Oct 14, 2025, 10:11 AM
v2-vercel (Inspect) 👍 Changes approved 9 changed Oct 14, 2025, 10:10 AM

Copy link
Contributor

@gregberge gregberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use Node.js v22 on Vercel, we should match it here.

@BrettJephson BrettJephson merged commit 75543b1 into main Oct 14, 2025
16 checks passed
@BrettJephson BrettJephson deleted the update-nvmrc branch October 14, 2025 10:13
- Node.js (Version: >=20.6)
- Node.js (Version: >= 22.3)
- Use `nvm` for easy Node management
- [Bun](https://bun.sh/) (Version: >=1.2.15)
Copy link

@Pumpman828 Pumpman828 Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregberge gregberge gregberge approved these changes

+1 more reviewer

@Pumpman828 Pumpman828 Pumpman828 left review comments

Reviewers whose approvals may not affect merge requirements

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /