-
-
Couldn't load subscription status.
- Fork 181
auth: suport ActionCodeSettings.linkDomain #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I haven't been able to test this since I haven't been able to resolve some issues with
mavenLocal. But this is basically a copy-paste-edit ofdynamicLinkDomainso it should work with, at most, trivial fixes.
I worked out a solution for my mavenLocal issues and confirmed success accordingly:
- android: works
- ios: works
- js: untested but seems likely to work
- jvm: unimplemented (not sure the proper way to implement)
Please let me know if there's anything I can do to help get this merged and released.
Thanks again!
happy for you to rebase yours and i will close mine otherwise:
#741
Platforms supported: * android * ios * js * NOT jvm
ec73ad5 to
cf894a3
Compare
@Reedyuk I just rebased on master and pushed my branch - anything else you need me to do? Thanks.
@nbransby are we ok to merge this in after updating the api check?
@treitter - can you run ./gradlew apiDump and commit the api file changes.
This adds the
ActionCodeSettings.linkDomainproperty to support custom domains in auth (overridding the defaultPROJECT_ID.firebaseapp.comauthentication links).This PR should fix issue 731.
Supported platforms:
Unsupported platforms:
I haven't been able to test this since I haven't been able to resolve some issues with
mavenLocal. But this is basically a copy-paste-edit ofdynamicLinkDomainso it should work with, at most, trivial fixes.