Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings
This repository was archived by the owner on Nov 26, 2020. It is now read-only.

Migration/wkwebview #388

Draft
OrbitalMan wants to merge 7 commits into FolioReader:master
base: master
Choose a base branch
Loading
from OrbitalMan:migration/wkwebview

Conversation

@OrbitalMan
Copy link

@OrbitalMan OrbitalMan commented Jun 9, 2020

Here is my attempt to finish what @ricardohg started.
Known issues so far:

  • You have to select a text couple of times in order to have an ability to play the audio from it.
  • The play button from menu also doesn't work before you select the text and make it to show play popup.
  • The pages counter doesn't always calculate correctly.

Copy link

Hello @OrbitalMan
We have check this wkwebview last commit. FolioReaderCenter.swift this file still using webview. please check and update
line 1291 let cell = ((scrollView.superview as? UIWebView)?.delegate as? FolioReaderPage)
Thanks

if (self?.readerConfig.scrollDirection == .horizontalWithVerticalContent),
let cell = ((scrollView.superview as? UIWebView)?.delegate as? FolioReaderPage) {
let cell = ((scrollView.superview as? WKWebView)?.navigationDelegate as? FolioReaderPage) {
let currentIndexPathRow = cell.pageNumber - 1
Copy link
Author

@OrbitalMan OrbitalMan Jul 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ThakarRajesh! I have already fixed the UIWebView reference - please take a look at commit 49076e4

Copy link

Hi,
When are you going to release WKWebview functionalities in FolioReader, we are waiting for it.
silviocandido, mspusta78, bimosektiw, AdnanMajeed06, rodfp, mrifni, ThakarRajesh, james-bltg, and SenDesignRO reacted with thumbs up emoji AdnanMajeed06 reacted with eyes emoji

Copy link

Hi,
Thanks for this pull request, Is there any solution of two columns config on WKWebview? like this feature:#343

Copy link

Hello @OrbitalMan
Type 'Bundle' has no member 'frameworkBundle' in FolioReaderScript.swift how to resolved this issue.

Copy link

hellbit commented Sep 29, 2020

Hey guys, who solved a problem with images? Right now WKWebView doesn't load images from epub.

Copy link

Hello @OrbitalMan , after migration, I ran into a problem with fonts, they just stopped working, I have some strange font working, something from the system

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /