Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix field evaluation in scaffolding #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cincuranet merged 2 commits into FirebirdSQL:master from bgrauer-atacom:master
Aug 22, 2023
Merged

Fix field evaluation in scaffolding #1133

cincuranet merged 2 commits into FirebirdSQL:master from bgrauer-atacom:master
Aug 22, 2023

Conversation

@bgrauer-atacom
Copy link
Contributor

@bgrauer-atacom bgrauer-atacom commented Aug 16, 2023 •
edited
Loading

@bgrauer-atacom bgrauer-atacom changed the title (削除) Fix nullable evaluation in scaffolding (削除ここまで) (追記) Fix evaluation in scaffolding (追記ここまで) Aug 18, 2023
Copy link
Contributor Author

Well, it was not my intention to put two issues into the same pull request.
Let me know if you prefer two seperate pull requests.

@bgrauer-atacom bgrauer-atacom changed the title (削除) Fix evaluation in scaffolding (削除ここまで) (追記) Fix field evaluation in scaffolding (追記ここまで) Aug 18, 2023
Copy link
Member

Single is fine.

Copy link
Contributor Author

Fixed invalid test table length.

Copy link
Member

Remove the ScaffoldingTestsBase and I'll merge.

Copy link
Contributor Author

Removed ScaffoldingTestsBase. Database objects are now not removed anymore.

Copy link
Member

Thanks for your contribution.

@cincuranet cincuranet merged commit 19ee5db into FirebirdSQL:master Aug 22, 2023
Copy link
Contributor Author

You are very welcome. Thanks for maintaining that project!
Let me know if you want my contribution in other issues.

Copy link
Member

You're welcome to do what spikes your interest. Don't forget to review CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cincuranet cincuranet cincuranet requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /