-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update samples/hey_gis_give_me_a_map_of_the_recent_natural_disasters #2117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
View / edit / reply to this conversation on ReviewNB
nanaeaubry commented on 2024年10月21日T08:08:04Z
----------------------------------------------------------------
We removed show styles for now... this is something we might want to re-imagine a bit before integrating since we now use the dataclasses. But no one-to-one as of now
View / edit / reply to this conversation on ReviewNB
nanaeaubry commented on 2024年10月21日T08:08:05Z
----------------------------------------------------------------
plot now takes a renderer dataclass rather than individual symbol information. So you make a simple renderer and add in the symbol there.
View / edit / reply to this conversation on ReviewNB
nanaeaubry commented on 2024年10月21日T08:08:06Z
----------------------------------------------------------------
You can replace with export_to_html since that is mentioned in the comment. But take screenshot we decided not to include. There is also a print method. So maybe change the text to:
" Alternatively, you can either print to PDF of the current map, or export it to a local HTML file. "
And then change the code to one or the other. Take screenshot was used because it shows the map rather than the file path is my guess
@nparavicini7 Left some comments for your questions, let me know if you need more info!
Updated the text and some of the mapping calls, but need some sage wisdom from Nanae about some of the other mapping stuff first before merging. Mainly:
Thanks and lmk :)