-
Notifications
You must be signed in to change notification settings - Fork 275
Fix "Undefined 0" fee tx UI #5808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Ensure we always have something to display for the crypto and fiat symbols when displaying fees. - If no crypto symbol is available, use the currency name instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Fee Display Fails with Empty Crypto Symbol
The fee display logic's condition transactionFee.cryptoSymbol != null doesn't account for cryptoSymbol being an empty string. When no symbol is available, a utility sets cryptoSymbol to '', preventing the currencyName fallback. This leads to an incorrect fee display, often with a leading space, instead of the intended currency name.
Uh oh!
There was an error while loading. Please reload this page.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Fixes Send fee text to show proper crypto/fiat symbols with currency-name fallback when symbols are missing or fees are zero; strengthens utility fee formatting and adds typing.
src/components/scenes/SendScene2.tsx):src/util/utils.ts):convertTransactionFeeToDisplayFee: addcurrencyName, provide fiat symbol/name fallback, handle empty fee amounts, and return defaults for zero-fee cases.Written by Cursor Bugbot for commit 4941864. This will update automatically on new commits. Configure here.