-
Notifications
You must be signed in to change notification settings - Fork 275
RampCreateScene not auto-populating a 500ドル buy amount
#5807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we adding this constraint? Why not have this default amount for sell too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes no UX sense. The amount is completely dependent on your balance and what you choose to sell. The buy flow's 500ドル default is an effort to improve our revenue.
Also, it was the task's ask and pretty sure aligns with our legacy behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the fix is:
const maxSpendExchangeAmount = await getMaxSpendExchangeAmount( selectedWallet, selectedCrypto.tokenId, denomination ) setExchangeAmount({ amount: Math.min(initialFiat, maxSpendExchangeAmount) })
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a153892 to
97e2250
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't remove the default for sell, instead fix it properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make a new task to add the auto populate to sell and assign it to me in develop sprint
Punted task (need concensus): https://app.asana.com/1/9976422036640/project/1201386023359452/task/1211745454961037?focus=true
Uh oh!
There was an error while loading. Please reload this page.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Fixes initial fiat auto-fill to only run for buys and when no amount is entered, and updates dependencies accordingly.
buyand only whenexchangeAmountis empty.'empty'check.direction.Written by Cursor Bugbot for commit 97e2250. This will update automatically on new commits. Configure here.