-
Notifications
You must be signed in to change notification settings - Fork 275
Accessibility setting compatible AirshipToast
#5803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@chatgpt-codex-connector
chatgpt-codex-connector
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
i️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Badge Keep AirshipToast honoring accessibility font size
Replacing the Text with EdgeText removes the allowFontScaling prop and switches the underlying element to allowFontScaling={false} (see EdgeText implementation). As a result, toast messages now ignore the user’s Dynamic Type setting and there is no way for callers to re‐enable scaling. Previously the toast respected accessibility font size by default and callers could opt out. This regression will cause unreadably small toasts for users who rely on larger fonts.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, this is the exact goal. The theme responds to the scaling setting, not individual text elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, this is the exact goal. The theme responds to the scaling setting, not individual text elements.
307f6b8 to
6cfb984
Compare
Uh oh!
There was an error while loading. Please reload this page.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Switches
AirshipToastto useEdgeTextwith unlimited lines, removesallowFontScalingprop, and updates the Dev test toast message.TextwithEdgeTextinsrc/components/common/AirshipToast.tsxand setnumberOfLines={0}for unlimited wrapping.allowFontScalingsupport fromPropsand usage.src/components/scenes/DevTestScene.tsxto reflect new scaling behavior.Written by Cursor Bugbot for commit 6cfb984. This will update automatically on new commits. Configure here.