Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix "Buy Crypto" auto-population #5801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jon-edge merged 1 commit into develop from jon/fix/buy-crypto
Oct 23, 2025
Merged

Fix "Buy Crypto" auto-population #5801

Jon-edge merged 1 commit into develop from jon/fix/buy-crypto
Oct 23, 2025

Conversation

@Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Oct 22, 2025
edited by cursor bot
Loading

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Ensures Buy Crypto preselects the current wallet/asset by passing a forcedWalletResult when navigating to pluginListBuy.

  • Buy flow:
    • src/components/themed/BuyCrypto.tsx:
      • Navigate to buyTabpluginListBuy with params: { forcedWalletResult } built from the current wallet.id and tokenId to preselect the asset.
      • Type tweaks: export as React.FC<Props>; import WalletListWalletResult.
      • Minor logic cleanup for allowedPluginIds filtering.
  • Changelog:
    • Add fix entry: BuyCrypto not auto-populating buy asset.

Written by Cursor Bugbot for commit 2f4055a. This will update automatically on new commits. Configure here.


chatgpt-codex-connector[bot] reacted with thumbs up emoji
type: 'wallet',
walletId: wallet.id,
tokenId
}
Copy link

@cursor cursor bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: BuyCrypto Button Renders Incorrectly

The BuyCrypto component passes tokenId in forcedWalletResult to the buy flow, but the button only renders when tokenId is null. This means tokenId will always be null when pressed, making its inclusion in navigation params ineffective and potentially causing type mismatches.

Fix in Cursor Fix in Web

@Jon-edge Jon-edge merged commit f18674b into develop Oct 23, 2025
3 checks passed
@Jon-edge Jon-edge deleted the jon/fix/buy-crypto branch October 23, 2025 20:40
Jon-edge added a commit that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@swansontec swansontec swansontec approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /