-
Notifications
You must be signed in to change notification settings - Fork 274
Log loginIds #5798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log loginIds #5798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String(error) should result in Error: ${error.message} if its an instance of Error. I can see why you wouldn't want the "Error: " prefix, but I can also see why you might want it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, just trying to preserve behavior here.
84ea6df to
372a420
Compare
372a420 to
16eb1fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Base58 Parsing Errors Block Log Uploads
Unhandled base58.parse() calls for user.loginId and rootLoginId can throw an error if the IDs are not valid base58 strings. This crashes the log generation process, preventing users from uploading critical diagnostic logs for support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But edge-core-js promises that they are in base58, so no problem.
Uh oh!
There was an error while loading. Please reload this page.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Include base64-encoded loginIds for all accounts in log uploads, with improved null checks and error typing.
loginIdfor all accounts in uploaded logs (src/actions/LogActions.tsx):userIdas base64-encodedloginIdforcontext.localUsers.loggedInUser.userIdfromrootLoginIdviabase58→base64.!= nullguards, explicit return types, andunknownerror handling.sendLogsnow returnsPromise<void>and improves fetch error handling.LogsModaltyping cleanups and clearer error messages when sending logs fails.loginIds in log uploads.Written by Cursor Bugbot for commit 16eb1fa. This will update automatically on new commits. Configure here.