-
Notifications
You must be signed in to change notification settings - Fork 275
Add a loading state for rampLastCryptoSelection #5782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
e7d6038 to
584128a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could optionally make AI happy, but not super important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see Cursor's point, but it shouldn't happen because selectedCrypto != null also implies selectedCryptoCurrencyCode != null, and so there's no case where this could happen.
If we want to be paranoid, we could put an extra || selectedCryptoCurrencyCode == null clause to make this explicit.
584128a to
86d734f
Compare
86d734f to
4ae1d80
Compare
Uh oh!
There was an error while loading. Please reload this page.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Introduce
useRampLastCryptoSelectionto await wallet readiness and updateRampCreateSceneto show a spinner and disable crypto input until selection loads.src/components/scenes/RampCreateScene.tsxto useuseRampLastCryptoSelectioninstead of local memoized selection.ActivityIndicatorin crypto dropdown, and disable crypto amount input while loading.src/hooks/useRampLastCryptoSelection.tsusing React Query to awaitaccount.waitForAllWallets()and return a validatedselectionwithisLoading.Written by Cursor Bugbot for commit 4ae1d80. This will update automatically on new commits. Configure here.