-
Notifications
You must be signed in to change notification settings - Fork 275
Fiat Providers Region Expansion #5752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few small things.
9ddafc5 to
cd6fc81
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cd6fc81 to
029d90b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated per-thread comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. Restored specific handling for user cancel (SendErrorBackPressed) and no-transaction (SendErrorNoTransaction), preserving the prior UX. Paybis still prefers segwit: getAddresses returns segwit first when present via the first element publicAddress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny change to address handling, and we're golden.
029d90b to
1a6f8b6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Addressed the latest three comments:
- paybisProvider: Use getAddresses + Array.find to prefer segwit when present, fallback to default publicAddress. Also removed redundant String(...) around fiat keys.
- banxaProvider: Same segwit selection via Array.find, and updated usages to avoid stale receiveAddress reference.
1a6f8b6 to
4bcaa2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, apart from one teeny typo.
56b580d to
6af5aa7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
6af5aa7 to
a75b119
Compare
Paybis and moonpay support this
For Florida support
a75b119 to
a0e10ae
Compare
Uh oh!
There was an error while loading. Please reload this page.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Adds Banxa ACH sell support and Moonpay Faster Payments (UK), with provider address handling and webview/deeplink flow refinements.
banxaProvider.ts): Enablesell.ach; add Banxa payment type→achmapping; switch polling tosetInterval; prefer segwit receive addresses; tighten types and error handling.moonpayProvider.ts): Add Faster Payments (gbp_bank_transfer) mapping and support (sell); improve deeplink/webview handlers and validation; minor fetch/US support checks refined.paybisProvider.ts): Prefer segwit receive addresses; harden deeplink/onUrlChange handlers and logging.src/constants/plugins/sellPluginList.json: RestrictfasterpaymentstoGB.Written by Cursor Bugbot for commit a0e10ae. This will update automatically on new commits. Configure here.