Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix long address font scaling #5746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jon-edge merged 1 commit into develop from jon/fix/unified-address-scale
Sep 19, 2025
Merged

Conversation

@Jon-edge
Copy link
Collaborator

@Jon-edge Jon-edge commented Sep 19, 2025 •
edited
Loading

image image

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

chatgpt-codex-connector[bot] reacted with thumbs up emoji
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few little cleanups here. We can do another round of review, or you can just fix & merge.

if (this.state.minimumPopupModalState[pluginId]) {
if (this.state.minimumPopupModalState[pluginId] === 'NOT_YET_SHOWN') {
const popupState = this.state.minimumPopupModalState[pluginId]
if (popupState != null) {
Copy link
Contributor

@swansontec swansontec Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the popupState === 'NOT_YET_SHOWN' test implies that popupState != null, you can just delete this line altogether.

<EdgeText>{fioToAddress + '\n'}</EdgeText>
)}
<EdgeText numberOfLines={3}>{recipientAddress}</EdgeText>
{/* TODO: Make EdgeText component support this use case */}
Copy link
Contributor

@swansontec swansontec Sep 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: We do have a component for this use-case, ParagraphText. It gets rid of the whole numberOfLines locking, and simply allows the text to flow as needed. But I see that your solution works too.

@Jon-edge Jon-edge force-pushed the jon/fix/unified-address-scale branch 3 times, most recently from 00d0a0f to 7dddb18 Compare September 19, 2025 20:51
@swansontec swansontec force-pushed the jon/fix/unified-address-scale branch from 7dddb18 to d8b798c Compare September 19, 2025 21:52
@Jon-edge Jon-edge force-pushed the jon/fix/unified-address-scale branch from d8b798c to 183d125 Compare September 19, 2025 22:21
@Jon-edge Jon-edge merged commit aaf90be into develop Sep 19, 2025
3 checks passed
@Jon-edge Jon-edge deleted the jon/fix/unified-address-scale branch September 19, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@swansontec swansontec swansontec approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /