Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Implement a new EdgeCarousel for the home scene #5744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swansontec merged 1 commit into develop from william/home-scene-carousel
Sep 19, 2025

Conversation

@swansontec
Copy link
Contributor

@swansontec swansontec commented Sep 18, 2025 •
edited
Loading

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

if (onPress != null) onPress(index)
}
return (
<Pressable key={index} hitSlop={theme.rem(0.2)} onPress={handlePress}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can further increase the hitSlop so there's no deadzones between the dots

Copy link
Contributor Author

@swansontec swansontec Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, but there's a problem where the previous dot becomes un-hittable. This is as wide as I could get it without breaking.

Jon-edge reacted with thumbs up emoji
Copy link
Collaborator

@Jon-edge Jon-edge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't warrant CHANGELOG?

cursor[bot]

This comment was marked as outdated.

@swansontec swansontec merged commit 2c01060 into develop Sep 19, 2025
3 checks passed
@swansontec swansontec deleted the william/home-scene-carousel branch September 19, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@Jon-edge Jon-edge Jon-edge approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /