-
Couldn't load subscription status.
- Fork 275
CoinRanking (Markets) UI fixes/updates #3990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4429eb5 to
77d416d
Compare
77d416d to
ed17730
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there's a good reason but I couldn't figure out why this feature is hardcoded to USD. I added a small fixup commit that uses the user's default fiat instead of USD for both components. If you use it the commit message should be changed before merging.
If there is a good reason to keep USD only feel free to drop the fixup and merge since it would be approved anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoiding scope creep since this PR is meant to be a fix for the rank and USD display. Also the proposed change would break the feature for fiat types not supported by the API.
Tracked this new idea in task: https://app.asana.com/0/1200382638405084/1203963276097127/f
e616ec4 to
4f457ab
Compare
Just a suggestion: may want to add a 1 or even 2 decimal precision to the market cap below the symbol:
Otherwise there is ambiguity if the values are both the same integer:
We actually already display decimal places in those fields. Since there's potentially less space here for smaller devices, and to keep the possibility of adding new columns, I'm willing to live with the discrepancy of Bn vs B, Mn vs M between the two CoinRank scenes.
Reorganize row contents into distinct columns Center justify the price and percent-change text
4f457ab to
a32723f
Compare
Uh oh!
There was an error while loading. Please reload this page.
Add CoinRanking scenes back to Main.tsx
Fix CoinRankScene styling
Add USD to CoinRankingDetailsScene
Screenshot 2023年02月10日 172805
CHANGELOG
noneDependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: