Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Optimize the py script CSV to Excel #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DhanushNehru merged 2 commits into DhanushNehru:master from Martinxux:master
Aug 20, 2024

Conversation

@Martinxux
Copy link
Contributor

@Martinxux Martinxux commented Aug 16, 2024
edited
Loading

PR Title

CSV to Excel Refactor & Fix

Summary

summary...

  • 🎨Refactor: Remove redundant code
  • 🐛Fix: The get_sheet_by_name method in the class Workbook has been deprecated

Description

Some of the code looks redundant and I don't think it's needed.
The "get_sheet_by_name" method in class "Workbook" is deprecated and "workbook[sheet_name]" should be used

The changes are as follows:

  • 🎨Refactor: Remove redundant code and add some exegesis
  • 🐛Fix: The get_sheet_by_name method in the class Workbook has been deprecated

Checks

in the repository

  • Made no changes that degrades the functioning of the repository
  • Gave each commit a better title (unlike updated README.md)

in the PR

  • Followed the format of the pull_request_template
  • Made the Pull Request in a small level (for the creator's wellfare)
  • Tested the changes you made

Thank You,

Martinxu

@DhanushNehru DhanushNehru merged commit 10e474a into DhanushNehru:master Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DhanushNehru DhanushNehru DhanushNehru approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /