-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[SDBM-2099] Fixes an issue querying table and index metrics on the public schema #21686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethsamuel
sethsamuel
approved these changes
Oct 16, 2025
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.29%. Comparing base (336c4cf) to head (6c7fcbf).
Additional details and impacted files
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Contributor
⚠️ Warnings
🧪 1 Test failed
test_common_metrics[False]fromtest_pg_integration.py(Datadog)Some metrics are collected but not asserted: Asserted Metrics: - dd.postgres.operation.time - postgresql.activity.wait_event - postgresql.archiver.archived_count - postgresql.archiver.failed_count - postgresql.before_xid_wraparound - postgresql.bgwriter.buffers_alloc - postgresql.bgwriter.buffers_backend - postgresql.bgwriter.buffers_backend_fsync ...
i️ Info
❄️ No new flaky tests detected
This comment will be updated automatically if new data arrives.🔗 Commit SHA: 6c7fcbf | Docs | Was this helpful? Give us feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What does this PR do?
This PR fixes an issue reported where the Postgres integration is querying non-existent columns when collecting table or index metrics on the public schema.
This was reproduced locally with the following config snippet
Previously this configuration would lead to the following exception while collecting relation metrics
This occurs because we hardcode adding nspname into our relations filter but our index and table queries had aliased the column name so it didn't exist. Now we're aligning the column aliases to this
nspnameconstant so that our filtering works properly.No impact on reporting metrics/tags on touched queries should be expected from the column alias changes
Motivation
Fixes issue and SDBM-2099
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged