-
-
Notifications
You must be signed in to change notification settings - Fork 246
Add explicit include of chrono header. #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robertocapuano
wants to merge
1
commit into
DanielChappuis:develop
from
robertocapuano:fix-chrono-include
Open
Add explicit include of chrono header. #421
robertocapuano
wants to merge
1
commit into
DanielChappuis:develop
from
robertocapuano:fix-chrono-include
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio Code doesn't find chrono namespace: include is needed
codecov-commenter
commented
May 4, 2025
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 56.19%. Comparing base (
7000610) to head (583fabe).
Report is 7 commits behind head on develop.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@ ## develop #421 +/- ## ======================================== Coverage 56.19% 56.19% ======================================== Files 182 182 Lines 13872 13872 Branches 1173 1173 ======================================== Hits 7796 7796 Misses 6076 6076
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
I confirm having the same problem on my Github actions workflow. I am building with
- CMake
- Ninja generator
- msvc compiler
C:\PROGRA~1\MICROS~22022円\ENTERP~1\VC\Tools\MSVC1444円~1.352\bin\Hostx64\x64\cl.exe /nologo /TP -ID:build\windows-msvc-debug\_deps\reactphysics3d-src\include /DWIN32 /D_WINDOWS /EHsc /Ob0 /Od /RTC1 -std:c++20 -MDd -Zi /showIncludes @_deps\reactphysics3d-build\CMakeFiles\reactphysics3d.dir\src\body\Body.cpp.obj.modmap /Fo_deps\reactphysics3d-build\CMakeFiles\reactphysics3d.dir\src\body\Body.cpp.obj /Fd_deps\reactphysics3d-build\CMakeFiles\reactphysics3d.dir\reactphysics3d.pdb /FS -c D:\build\windows-msvc-debug\_deps\reactphysics3d-src\src\body\Body.cpp
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(129): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(129): error C2039: 'now': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio2022円\Enterprise\VC\Tools\MSVC14円.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(129): error C3536: 'now': cannot be used before it is initialized
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(130): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(130): error C2039: 'to_time_t': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio2022円\Enterprise\VC\Tools\MSVC14円.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(130): error C3861: 'to_time_t': identifier not found
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(187): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(187): error C2039: 'now': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio2022円\Enterprise\VC\Tools\MSVC14円.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(187): error C3536: 'now': cannot be used before it is initialized
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(188): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(188): error C2039: 'to_time_t': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio2022円\Enterprise\VC\Tools\MSVC14円.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(188): error C3861: 'to_time_t': identifier not found
@robertocapuano
robertocapuano
changed the title
(削除) Add explicit include of chrone header. (削除ここまで)
(追記) Add explicit include of chrono header. (追記ここまで)
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio Code doesn't find chrono namespace: include is needed