Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add problem status to the team problem set page. #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meisterT wants to merge 1 commit into DOMjudge:main
base: main
Choose a base branch
Loading
from meisterT:team_problem_status

Conversation

@meisterT
Copy link
Member

@meisterT meisterT commented Oct 4, 2025

Example:
image

Copy link
Member

@nickygerritsen nickygerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

Copy link
Member

@vmcj vmcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels out of place in that location,

I think the score doesn't add that much extra information for correct solutions, and if we remove it we could gray out (I would pick green) the problems and have the same effect?

Instead of the score we could in the future add the new rank in case the team solves the problem.

Copy link
Member Author

meisterT commented Oct 4, 2025

It feels out of place in that location,

Happy to try out other locations, which ones should we try out?

I think the score doesn't add that much extra information for correct solutions, and if we remove it we could gray out (I would pick green) the problems and have the same effect?

You mean color the background of the card, I actually tried that first and it looked horrible with the green submit button and the green-ish boxes.

Instead of the score we could in the future add the new rank in case the team solves the problem.

I don't like it so much because it requires (A) explanation to the team, and (B) is largely independent of the problem to solve (modulo penalty time).

Copy link
Member Author

meisterT commented Oct 4, 2025

I think the score doesn't add that much extra information for correct solutions, and if we remove it we could gray out (I would pick green) the problems and have the same effect?

You mean color the background of the card, I actually tried that first and it looked horrible with the green submit button and the green-ish boxes.

See this screenshot for one example shade that I tried, other's didn't work better in my experience:
image

Copy link
Member Author

meisterT commented Oct 4, 2025

It feels out of place in that location,

Happy to try out other locations, which ones should we try out?

Or something like this?
image

Copy link
Contributor

Kevinjil commented Oct 4, 2025

I like this card the most:
image
Perhaps we can align the icon with the problem badge?

Copy link
Member Author

meisterT commented Oct 4, 2025

I find the green background with the other greens in the box quite ugly :-)

I can see how easy it is to align things

Copy link
Member Author

meisterT commented Oct 5, 2025

@Kevinjil one way to solve the alignment problem would be moving the problem badge to the left:
image

What are everyone's thoughts on the options?

Copy link
Member

eldering commented Oct 5, 2025

one way to solve the alignment problem would be moving the problem badge to the left:
What are everyone's thoughts on the options?

I don't like it so much: this way the problem badge seems less pronounced and more easily confused with a green/red (un)solved badge. And I think the problem badges should be the most obvious discernable thing here.

Kevinjil reacted with thumbs up emoji

Copy link
Member

vmcj commented Oct 6, 2025

I didn't check how it looked but the reason a team visits this page after the contest start is to pick a next problem. Could we split the page in 2?
Unsolved problems:
[Card C like you have it initially] [Card E] [Card G]
[Card H]
Solved problems:
[Card B] [Card C] [Card D]
[Card F] [Card I]

I suspect that the new badge is less out of place in that case (for me).

Copy link
Member

I think people also use the page to download samples or testing tools, if you don't provide them.

I'm not entirely sure if not having the problems in contest order is the way to go.

If people indeed visit this page mainly to pick the next problem, then we should sort them by number of correct attempts by other teams. I'm not suggesting we do that though.

Copy link
Member

vmcj commented Oct 6, 2025

I think people also use the page to download samples or testing tools, if you don't provide them.

I'm not entirely sure if not having the problems in contest order is the way to go.

If people indeed visit this page mainly to pick the next problem, then we should sort them by number of correct attempts by other teams. I'm not suggesting we do that though.

What I propose is contest order, I just propose to do it twice. In case you re-visit the page you would want to see the problem's you haven't solved yet. Another sorting option with sorted by Solved/Tried or even #solved would be an option but what I'm suggesting is to move stuff out of view which is most likely not relevant anymore (similar for disabled languages, non-activated contests etc.).

Copy link
Member

I do really wonder if that fixes the issue with it not looking good with Tobi's addition though. And it will move stuff around still, even though it's in order.

But I might be wrong and maybe that is exactly what people want.

Copy link
Member Author

meisterT commented Oct 6, 2025

I think it is worth a try. There is also another option that came to mind: gray out the whole card if a problem has been solved. Do not add any indication to the attempted problems. I will try out both and add screenshots. And then we should probably ask in Slack or so to vote for options :-)

Copy link
Member

eldering commented Oct 6, 2025

A side comment: I'd try changing to the color of the submit button from green to something a bit less outstanding: I think the color green creates a "conflict" with the green solved badge.

Copy link
Member

eldering commented Oct 6, 2025

And what do the two rows of boxes actually mean? The fact that I don't know makes me wonder if we could remove those and declutter the page a bit.

Copy link
Member

And what do the two rows of boxes actually mean? The fact that I don't know makes me wonder if we could remove those and declutter the page a bit.

Hovering over them does give you a hint:
image

I do think it's useful, but maybe we can not show it by default or something?

Copy link
Member Author

meisterT commented Oct 6, 2025

I think the boxes are super useful and if you hover over them once you understand the concept. We should document them in the team manual though.

but maybe we can not show it by default or something

I think that's worse than dropping them. We should be careful with adding options, especially to the team interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmcj vmcj vmcj left review comments

@nickygerritsen nickygerritsen nickygerritsen approved these changes

@eldering eldering eldering approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /