-
Notifications
You must be signed in to change notification settings - Fork 279
Version control javascript libraries with NPM #3124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If we do this, I'd suggest going for npm (or yarn) fully for JS dependencies
If we do this, I'd suggest going for npm (or yarn) fully for JS dependencies
So also remove JS dependencies in composer and add them in npm? I'm fine with either of the 2 but for adaptation doing it in composer is an easier learningpath.
I somehow never used yarn but if that's the better of the 2 but I have no experience with that translation path.
I also think we should only do this in the next release so we have some time to discuss.
If we do this, I'd suggest going for npm (or yarn) fully for JS dependencies
So also remove JS dependencies in
composerand add them innpm? I'm fine with either of the 2 but for adaptation doing it incomposeris an easier learningpath.I somehow never used
yarnbut if that's the better of the 2 but I have no experience with that translation path.I also think we should only do this in the next release so we have some time to discuss.
I think it doesn't make sense to have 2 package managers for frontend dependencies, that's why I suggest using npm (or yarn, which can read the same package.json file) for all.
d4096af to
3bfe280
Compare
The other packages are harder to either find (dataTables) or don't work 1-on-1 (font-awesome). I'll look at those in another PR. Reviewing is easiest commit by commit and by just skipping the monaco one as that's the one touch most files.
Per commit we'll put the JS frontend libraries under control of a javascript dependency manager similar to composer for PHP.
This requires removing it from composer and adding it to yarn.
Default it seemed to pick a development version. This complains that it requires d3 also, that will be in the next commits.
This also fixes the issue that d3 as dependency is missing for nv3, note that we can't update d3 yet because of this dependency.
3bfe280 to
93a8a94
Compare
NPM is another packagemanager for JS. So we use composer first and when we can't find the package there we check with npm.
This change does require more changes for maintainer-install & any checkout.
If we do this it makes introducing MathJax a lot easier and we can now also version control other javascript libraries.