-
Couldn't load subscription status.
- Fork 279
Removes unneeded transactions. #2909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eda63ec to
73b1804
Compare
73b1804 to
f427290
Compare
14f4141 to
9284d1c
Compare
9284d1c to
00f98e2
Compare
Just the first three transactions. But can be merged. Probably easiest to check commit-by-commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doctrine 🤯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything to be handled? If there is no outstanding that we would disable here, we don't have an issue, do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, I'll remove.
Reading this back, this cannot be correct! I've had to create a manual query for updates with joins. 🤯
Apparently this case is never hit in the testsuite either.
Tried removing this transaction for the removal of all unneccesary transactions. It turns out that this is actually a valid usecase that should be kept.
Discussed with @tuupke this one shouldn't be merged yet.
No description provided.