Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Look in more directories for Postgres binaries #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbandy wants to merge 1 commit into CrunchyData:main
base: main
Choose a base branch
Loading
from cbandy:postgres-paths

Conversation

@cbandy
Copy link
Member

@cbandy cbandy commented Sep 30, 2025

This is similar to #4304, but for PostgresCluster and Postgres images.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Other

Other Information:

The last piece missing from the upgrade image is the pgbackrest command.

Issue: PGO-864

Copy link
Contributor

@benjaminjb benjaminjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm curious about some of the knock-on effects of these changes / what potential issues we're warding off.

cbandy

This comment was marked as resolved.

@cbandy cbandy marked this pull request as draft September 30, 2025 21:58

container.Command = []string{"patroni", configDirectory}
// Start Patroni in an environment that prioritizes executables of the specified Postgres version.
// NOTE: Patroni ignores PATH when "postgresql.bin_dir" is set.
Copy link
Collaborator

@jmckulk jmckulk Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could users set this and break something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Patroni reads this setting from YAML files or environment variables, neither of which is configurable.

jmckulk reacted with thumbs up emoji

This comment was marked as resolved.

This makes PostgresCluster compatible with images from other distros.
Issue: PGO-864
@cbandy cbandy marked this pull request as ready for review October 6, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminjb benjaminjb benjaminjb approved these changes

@jmckulk jmckulk jmckulk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /