Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update README.md #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nico-Strecker wants to merge 1 commit into Cosium:master from Nico-Strecker:master
Closed

Update README.md #79

Nico-Strecker wants to merge 1 commit into Cosium:master from Nico-Strecker:master

Conversation

@Nico-Strecker
Copy link

@Nico-Strecker Nico-Strecker commented Nov 6, 2022

Fix manual that new users have a smoother start with the library.

Copy link
Author

@reda-alaoui i hope you consider merging it.

Copy link
Member

reda-alaoui commented Nov 13, 2022
edited
Loading

I don't wish to parrot Spring Data JPA documentation in this project, because I won't maintain this kind of synchronisation.

Also, using the basePackage attribute is clearly optional. We can see the sample working without it. So it makes no sense to let a user think this is mandatory.

I understand that most Spring Boot users are clueless about @EnableJpaRepositories since the whole annotation declaration is optional in their context. On the other hand, non Spring Boot users had to use @EnableJpaRepositories to make their applications work with Spring Data JPA.

My conclusion is that the Quick start @EnableJpaRepositories section should be more geared toward Spring Boot users. 5a6104a should fix that without parroting Spring Data JPA documentation.

Nico-Strecker reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /