Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added EntityGraphUtils.fromAttributePaths #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reda-alaoui merged 2 commits into Cosium:master from goulashify:feature/fromAttributePaths
Feb 28, 2017

Conversation

@goulashify
Copy link
Contributor

@goulashify goulashify commented Feb 28, 2017
edited
Loading

Added a fromAttributePaths(String...) static to EntityGraphUtils which works similarly to Spring's ad-hoc queries (see 60th example and readme.md diff). It resolves issue #3.

Copy link

Codecov Report

Merging #4 into master will increase coverage by 2.42%.
The diff coverage is 100%.

@@ Coverage Diff @@
## master #4 +/- ##
============================================
+ Coverage 75.28% 77.71% +2.42% 
- Complexity 0 103 +103 
============================================
 Files 20 20 
 Lines 348 350 +2 
 Branches 49 40 -9 
============================================
+ Hits 262 272 +10 
+ Misses 70 64 -6 
+ Partials 16 14 -2
Impacted Files Coverage Δ Complexity Δ
...data/jpa/entity/graph/domain/EntityGraphUtils.java 85.71% <100%> (+2.38%) 5 <1> (+5)
.../support/RepositoryMethodEntityGraphExtractor.java 86.07% <0%> (+2.53%) 9% <0%> (+9%)
...a/jpa/entity/graph/domain/AbstractEntityGraph.java 57.14% <0%> (+4.76%) 5% <0%> (+5%)
...ta/jpa/entity/graph/domain/DynamicEntityGraph.java 45.45% <0%> (+45.45%) 3% <0%> (+3%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c91188...0fad65d. Read the comment docs.

@reda-alaoui reda-alaoui merged commit 1fd3741 into Cosium:master Feb 28, 2017
Copy link
Member

Great work Dan. Thanks !

goulashify reacted with thumbs up emoji

@goulashify goulashify deleted the feature/fromAttributePaths branch February 28, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /