Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add equals/hashCode implementations to the EntityGraph classes #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reda-alaoui merged 2 commits into Cosium:master from thyming:equals-hashcode-implementations
Dec 13, 2018

Conversation

@thyming
Copy link
Contributor

@thyming thyming commented Dec 12, 2018 •
edited
Loading

Closes #21.

Copy link

codecov-io commented Dec 12, 2018 •
edited
Loading

Codecov Report

Merging #22 into master will increase coverage by 1.05%.
The diff coverage is 72.22%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #22 +/- ##
============================================
+ Coverage 77.83% 78.89% +1.05% 
- Complexity 102 116 +14 
============================================
 Files 22 22 
 Lines 361 379 +18 
 Branches 44 52 +8 
============================================
+ Hits 281 299 +18 
+ Misses 66 62 -4 
- Partials 14 18 +4
Impacted Files Coverage Δ Complexity Δ
...ta/jpa/entity/graph/domain/DynamicEntityGraph.java 72.22% <55.55%> (+16.66%) 9 <5> (+6) ⬆️
...data/jpa/entity/graph/domain/NamedEntityGraph.java 95% <88.88%> (-5%) 13 <7> (+7)
...a/jpa/entity/graph/domain/AbstractEntityGraph.java 68.42% <0%> (+10.52%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f63315...233b32e. Read the comment docs.

Copy link
Member

Thank you @thyming .
Could you add tests on the two classes?

Copy link
Contributor Author

thyming commented Dec 13, 2018

Sure thing, done.

@reda-alaoui reda-alaoui merged commit cc4f82a into Cosium:master Dec 13, 2018
Copy link
Member

Thank you @thyming
I am releasing right now.

Copy link
Contributor Author

thyming commented Dec 13, 2018 via email

Thanks!
...
On Thu, Dec 13, 2018 at 11:20 AM Réda Housni Alaoui < ***@***.***> wrote: Thank you @thyming <https://github.com/thyming> I am releasing right now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#22 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACHW6XuQ3n7LJkt5ecOe1MLzoWj9jmK8ks5u4n5kgaJpZM4ZP83B> .

Copy link
Member

2.0.7 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /