Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix type information when using dynamic projection and generic repository #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reda-alaoui merged 6 commits into Cosium:master from leassis:fix-type-information
Dec 27, 2023

Conversation

@leassis
Copy link
Contributor

@leassis leassis commented Dec 25, 2023 •
edited
Loading

fix: the type information when using generic repository along with dynamic projections.

closes #148

Copy link
Member

Hello @leassis ,
Please fix the formatting issue.

Copy link
Contributor Author

leassis commented Dec 26, 2023

Do you have a standard formatter?

Copy link
Member

Yes, this one

You can run this to format your code.
leassis reacted with thumbs up emoji

Copy link
Contributor Author

leassis commented Dec 26, 2023

done!

Copy link
Member

@reda-alaoui reda-alaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me.

But this introduces a breaking change regarding the support of Spring Data JPA. Therefore, the README's Compatibility matrix (https://github.com/Cosium/spring-data-jpa-entity-graph?tab=readme-ov-file#compatibility-matrix) should be changed to show that:

  • Spring Data JPA 3.2.1+ is supported by Spring Data JPA Entity Graph 3.2.2+
  • Spring Data JPA 3.2.0 is supported by Spring Data JPA Entity Graph 3.2.0-3.2.1

@reda-alaoui reda-alaoui changed the title (削除) fix type information when using dinamic projection and generic repository (削除ここまで) (追記) Fix type information when using dynamic projection and generic repository (追記ここまで) Dec 26, 2023
@reda-alaoui reda-alaoui merged commit 4bcc022 into Cosium:master Dec 27, 2023
Copy link
Member

Thank you @leassis !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reda-alaoui reda-alaoui reda-alaoui approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

version 3.2.1 is losing jpa parameters type when using dynamic projections and generics

AltStyle によって変換されたページ (->オリジナル) /