-
Notifications
You must be signed in to change notification settings - Fork 53
Update to Spring Data 2.0.0.RC3 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This makes it easier for people to clone the repo and build spring-data-jpa-entity-graph:2.0.0-SNAPSHOT locally (as there is no release yet compatible with Spring Boot 2.0)
Hello @marceloverdijk ,
Thanks for the PR.
Travis is complaining about the new dependency.
I guess you didn't have this issue?
Hi @reda-alaoui no I did't have this issue, probably because the Spring Data 2.0.0. RC3 artifacts were already in my local Maven repository.
I see Travis is trying to download it from https://repo.spring.io/libs-snapshot-local, and the milestones are stored in https://repo.spring.io/libs-milestone-local/.
I think you have to add that to your src/site/resources/settings.xml configuration and it should work.
Ok, can you add the milestone repository to src/site/resources/settings.xml to make the build pass?
I've added it but still fails.
How does your project resolve the snapshot deps then?
I see this `before_install:
- curl -o $HOME/.m2/settings.xml https://raw.githubusercontent.com/Cosium/spring-data-jpa-entity-graph/$TRAVIS_BRANCH/src/site/resources/settings.xml` in
.travis.yml.
So probably have to first merge the PR as it downloads thesettings.xmlbefore the build.
Correct.
Let's merge it ;)
Build OK on master !
👍
This makes it easier for people to clone the repo and build spring-data-jpa-entity-graph:2.0.0-SNAPSHOT locally (as there is no release yet compatible with Spring Boot 2.0)