Sourcery Starbot ⭐ refactored ComputerScientist-01/Advanced-Programming-Practice #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ComputerScientist-01 merged 1 commit into ComputerScientist-01:main from SourceryAI:main

Jul 8, 2021

Merged

Sourcery Starbot ⭐ refactored ComputerScientist-01/Advanced-Programming-Practice #16

ComputerScientist-01 merged 1 commit into ComputerScientist-01:main from SourceryAI:main

Jul 8, 2021

Conversation

@SourceryAI

Copy link

Contributor

@SourceryAI SourceryAI commented Jul 8, 2021

Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨

Here's your pull request refactoring your most popular Python repo.

If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.

Review changes via command line

To manually merge these changes, make sure you're on the main branch, then run:

git fetch https://github.com/sourcery-ai-bot/Advanced-Programming-Practice main
git merge --ff-only FETCH_HEAD
git reset HEAD^

@SourceryAI


 'Refactored by Sourcery'

a62d6d2

SourceryAI

SourceryAI commented

Jul 8, 2021

View reviewed changes

Week 1/SET 11/Task-5.py

Comment on lines -3 to +8

tot = 0

print("Enter Marks Obtained in different exams: ")

for i in range(5):

marks.insert(i, input())

#print(marks[i])

for i in range(5):

tot = tot + int(marks[i])

tot = sum(int(marks[i]) for i in range(5))

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 3-10 refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)
Convert for loop into call to sum() (sum-comprehension)

Week 1/SET 14/ques4.py

sum = 0

for digit in str(n):

sum += int(digit)

sum = sum(int(digit) for digit in str(n))

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function sumofDigits refactored with the following changes:

Convert for loop into call to sum() (sum-comprehension)

Week 2/SET 11/q1.py

Comment on lines -40 to +47

temp = num;

while(temp):

last_digit = temp % 10;

temp = int(temp / 10);

dec_value += last_digit * base;

base =base* 2;

base *= 2;

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function binaryToDecimal refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

Week 2/SET 11/q2.py

Comment on lines -7 to +9

for x in range(max(num,0)):

print(row)

row=[l+r for l,r in zip(row+y, y+row)]

for _ in range(max(num,0)):

print(row)

row=[l+r for l,r in zip(row+y, y+row)]

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function pascal_triangle refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

Week 2/SET 11/q4.py

Comment on lines 4 to 17

m = dict()

m = {}

li = ['x','y','z']

s = 11;

for l in li:

val = list()

for i in range(9):

val = []

for _ in range(9):

val.append(s)

s+=1

s =s+1

s +=1

m[l] = val

print(m)

for kin m.keys():

print(m[k][4])

for k, vin m.items():

print(v[4])

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 5-17 refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)
Replace list() with [] (list-literal)
Replace dict() with {} (dict-literal)
Remove unnecessary call to keys() (remove-dict-keys)
Replace unused for index with underscore (for-index-underscore)
Use items() to directly unpack dictionary values (use-dict-items)

Week-5/form.py

Comment on lines -56 to -62

i = 0

for STFORM3 in select:

for i, STFORM3 in enumerate(select):

for j in range(len(STFORM3)):

e = Entry(my_w, width=10, fg='blue')

e.grid(row=i, column=j)

e.insert(END, STFORM3[j])

i = i+1

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function display refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)
Replace manual loop counter with call to enumerate (convert-to-enumerate)

Week-5/registration_form_with_sql.py

cursor.execute("SELECT * FROM user_details")

i=1

for users in cursor:

for i, users in enumerate(cursor, start=1):

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function users_registered refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)
Replace manual loop counter with call to enumerate (convert-to-enumerate)

Week-6/Mutliprogramming/Week06 Set08.py

n = random.randint(10,20)

if obj._value+n <= MAX:

for i in range(n):

for _ in range(n):

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function producer_func refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

Week-6/Mutliprogramming/Week06 Set08.py

n = random.randint(1,20)

if obj._value+n >= 0:

for i in range(n):

for _ in range(n):

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function consumer_func refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

Week-6/Mutliprogramming/Week06 Set10.py

if __name__ == '__main__':

for i in range(0, 10):

for _ in range(10):

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 35-35 refactored with the following changes:

Replace range(0, x) with range(x) (remove-zero-from-range)
Replace unused for index with underscore (for-index-underscore)

SourceryAI

SourceryAI commented

Jul 8, 2021

View reviewed changes

Week-6/Socket/Set3/server3.py

Comment on lines -18 to -19

else:

pass

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 18-19 refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

Week-6/Socket/Set4/client4.py

# We are going to check for both - if one of them - that's expected, means no incoming data, continue as normal

# If we got different error code - something happened

if e.errno !=errno.EAGAINande.errno!=errno.EWOULDBLOCK:

if e.errno notin [errno.EAGAIN, errno.EWOULDBLOCK]:

Copy link

Contributor Author

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 79-79 refactored with the following changes:

Replace multiple comparisons of same variable with in operator (merge-comparisons)

@ComputerScientist-01 ComputerScientist-01 merged commit 04e2d85 into ComputerScientist-01:main

Jul 8, 2021

Sourcery Starbot ⭐ refactored ComputerScientist-01/Advanced-Programming-Practice #16

Sourcery Starbot ⭐ refactored ComputerScientist-01/Advanced-Programming-Practice #16

Uh oh!

Conversation

@SourceryAI SourceryAI commented Jul 8, 2021

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

@SourceryAI SourceryAI Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants