-
Notifications
You must be signed in to change notification settings - Fork 1.4k
WinUI - Fix DataGrid scroll performance issue #4867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamplonka
wants to merge
1
commit into
CommunityToolkit:winui
from
adamplonka:winui-fix-scroll-performance
Open
WinUI - Fix DataGrid scroll performance issue #4867
adamplonka
wants to merge
1
commit into
CommunityToolkit:winui
from
adamplonka:winui-fix-scroll-performance
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Apr 12, 2023
Thanks PlonkaAdam for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌
@dotnet-policy-service agree
Trolldemorted
commented
Oct 31, 2023
This PR has been open for half a year, could you either merge it or request changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #2122
Fixes DataGrid scroll performance issue for large data sources.
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
The DataSource set in
DataGridDataConnectionclass is (almost) always of typeICollectionViewwhich implements genericIList<>but doesn't implementIList. This causes fallback to list enumeration to reach the current index..current.mp4
What is the new behavior?
The fix adds support for
ICollectionViewDataSource and accesses the items directly by their index.An approach for
PagedCollectionView(from Silverlight) can be merged with the fix as it implements the same interface.fixed.2.mp4
PR Checklist
Please check if your PR fulfills the following requirements:
Other information