-
Couldn't load subscription status.
- Fork 122
Improved responsiveness of Showcase form & removed empty ruleset. #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for codingtrain ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
I like it! Could we try using 100% instead of arbitrary pixel values, and apply them to the --small (600px) breakpoint instead? That way the fields will fill up the width more consistently and we'll get rid of the remaining broken state between 400px and ~525px browser width.
As for removing the empty root css class in the tracks Header component, it wasn't bothering me since most components are structured with a root class and roughly 5 of them are empty.
If we do want to remove the empty class properly though, the reference to it in the component should also be deleted:
Hi @Zack-Dx did you mean to close this? I would like to incorporate it! Apologies for not following up about it sooner.
Hi @Zack-Dx did you mean to close this? I would like to incorporate it! Apologies for not following up about it sooner.
No issues Shiffman, I'll create a new PR fixing this. I'm just busy these days a bit due to my exams. I'll fix it by the upcoming weekend. Thanks, I love you.
Hello, I noticed that the submission form select and fields were not responsive for a device with a maximum width of 400px.
Before:
BeforeAfter I fixed it, ensuring the rest of the responsive elements are in place:
After