Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

grid helper #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonnytest1 wants to merge 1 commit into CodingTrain:main from jonnytest1:main
Closed

grid helper #39

jonnytest1 wants to merge 1 commit into CodingTrain:main from jonnytest1:main

Conversation

@jonnytest1
Copy link

@jonnytest1 jonnytest1 commented Jul 15, 2022
edited
Loading

made a small helper class for general grid layouts (partially copied from things i did previously)

its currently still not integrated perfectly so its just here as an idea

im thinking it might be unifiable if
Cell.down etc was expressed as Cell[createVector(0,-1)]

because then it possible to just invert the directional offset vector to reference the validOptions of a connection

(since this would be a slightly bigger change i stopped halfway through because i thought i'd get some feedback before rewriting it all ^^)

some more ideas can be gleaned off this class structure i made a while ago
https://github.com/jonnytest1/workadventure-mapserver/blob/master/resources/mapserver/service/generic-map-factory/game-map-map-factory.ts
for a minesweeper game

Copy link
Member

shiffman commented Jan 26, 2025
edited
Loading

Many apologies!!! I know it's been almost 3 years since these PRs! I am releasing a new video next week on the overlapping model and did some work to refactor this repository. Would you like to revisit this? Because it introduces typescript and additional complexity it likely makes more sense for me to link out to this from the repo's README. Let me know what you think!

Copy link
Author

phew ^^ i have no clue what that was anymore

you can definitely link to it if you want

(as for the typescript , i dont think its a big problem since this is jsdoc , it runs just fine in any javascript environment 🤔)

shiffman added a commit that referenced this pull request Jan 26, 2025
Copy link
Member

Ah, I see what you mean re: typescript. It's more that I am trying to keep this repo simple for p5.js coders who are often beginners and not familar with the broader JS ecosystem. Closing this and we can discusss in #46 Thank you!

shiffman added a commit that referenced this pull request Jan 26, 2025
* Adding community contribution
Re: #39
* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /