Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed 039 Mad Libs #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiffman merged 2 commits into CodingTrain:main from DenisovichDev:madlibs-fix
Oct 19, 2022
Merged

Fixed 039 Mad Libs #5

shiffman merged 2 commits into CodingTrain:main from DenisovichDev:madlibs-fix
Oct 19, 2022

Conversation

@DenisovichDev
Copy link
Member

@DenisovichDev DenisovichDev commented Oct 18, 2022

This PR fixes the code in 039 Mad Libs Generator.

Because of some changes in Google Sheets tabletop.js has been deprecated since 2020. But something similar is possible to do with the Papa Parse library. I have made changes as per that.

Tagging @shiffman to change the web editor version as well

Copy link
Member

Wonderful, thank you for adding the documentation comments!

DenisovichDev reacted with hooray emoji

@shiffman shiffman merged commit 1117185 into CodingTrain:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /