-
Notifications
You must be signed in to change notification settings - Fork 216
Fix test password_does_not_match and improve CI workflow #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test password_does_not_match and improve CI workflow #73
Conversation
Hi @borjapazr!
Sorry for not reviewing this PR on time when you firstly submitted it. Our fault 🙏
However, I have received the close PR notification now, and the modifications seems totally appropriate. Would you mind if I reopen the PR and merge it?
Thanks a lot for submitting it!
Hi @JavierCane.
You don't even have to apologize 😊. I was reviewing the old PRs I had opened and closed because I thought maybe you had already thought of another way to solve it.
I'm happy to reopen it.
Thanks for the feedback and for your day to day work 🚀
CodelyTV rocks! 🤘
Sometimes the randomly generated password for the
AuthenticateUserCommandmatches the randomly generatedAuthUserpassword. Because of this, thethrow_an_exception_when_the_password_does_not_matchtest fails.This issue has been fixed and the GH Actions CI workflow has also been updated.