-
Couldn't load subscription status.
- Fork 246
Root ordering #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexeyMatskevich
wants to merge
2
commits into
ClosureTree:master
from
AlexeyMatskevich:root_ordering
Open
Root ordering #442
AlexeyMatskevich
wants to merge
2
commits into
ClosureTree:master
from
AlexeyMatskevich:root_ordering
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derek-etherton-opslevel
added a commit
to OpsLevel/closure_tree
that referenced
this pull request
Mar 12, 2025
derek-etherton-opslevel
commented
Mar 13, 2025
We ran into the same issue. Our application uses multi-tenant, so it's critical that ordering is scoped per tenant instead of across the entire database.
This fix worked well for us, thanks @AlexeyMatskevich! Hope to see a future release with this included so that we don't need to maintain a fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Within the current implementation with root ordering there is a problem described in the readme
Also, changing the order of the root nodes is quite problematic since they are ordered globally as mentioned earlier.
Typical situation - I want to get all root blocks of a user and change their order:
But in this case, the sort_order for all root nodes of one user will be a sparse sequence of 1, 10, 48 ....
I was thinking that in the case where
parent_id = nil, you could rely on associations to restrict sort_order to root nodes within the association scope.My option to implement this as simply as possible is to add an
order_belong_tooption, through which the foreign key field for the corresponding association is provided.