Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added: database_type to configuration #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lizdeika wants to merge 1 commit into ClosureTree:master
base: master
Choose a base branch
Loading
from lizdeika:add-database_type-to-configuration

Conversation

@lizdeika
Copy link

@lizdeika lizdeika commented Apr 4, 2019
edited
Loading

Based on #338

Adds ability to set database_type in initializers/closure_tree_config.rb:

ClosureTree.configure do |config|
 config.database_type = :mysql
end

The type will be used across all the closure tree models in the application.

This solves problems with numeric ordering and db:create.

mid, snk, Arunijus, drawgas, AurimasLazdauskas, pirminis, mrancys, and piktas-eziukas reacted with thumbs up emoji n-rodriguez reacted with thumbs down emoji giedriusr, drawgas, pirminis, mrancys, mid, and snk reacted with rocket emoji
@lizdeika lizdeika force-pushed the add-database_type-to-configuration branch from c92002c to 232352f Compare December 3, 2019 15:35
@lizdeika lizdeika force-pushed the add-database_type-to-configuration branch from 232352f to b6019ac Compare January 27, 2020 12:05
Copy link
Author

Hi,
Any possibility to have this released?
Thank you

mid, snk, Arunijus, piktas-eziukas, pirminis, mrancys, and monai reacted with thumbs up emoji n-rodriguez reacted with thumbs down emoji

Copy link
Member

seuros commented May 11, 2020

How we will handle this with activerecord 6 that support multiple database.?

n-rodriguez reacted with thumbs up emoji

@lizdeika lizdeika force-pushed the add-database_type-to-configuration branch from b6019ac to df3446e Compare November 6, 2020 09:56
Copy link
Contributor

IMHO this one is better #338 since it's compatible with Rails 6 multi DB support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /