Added dont_order_roots option #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mceachen merged 1 commit into ClosureTree:master from thecartercenter:no_reorder_with_parent_id_nil

Jun 11, 2018

Merged

Added dont_order_roots option #312

mceachen merged 1 commit into ClosureTree:master from thecartercenter:no_reorder_with_parent_id_nil

Jun 11, 2018

Conversation

@smoyte

Copy link

Contributor

@smoyte smoyte commented May 30, 2018

From the proposed Readme text:

By default, root nodes are also assigned order values globally across the whole database table. So for instance if you have 5 nodes with no parent, they will be ordered 0 through 4 by default. If your model represents many separate trees and you have a lot of records, this can cause performance problems, and doesn't really make much sense.

This PR adds an option for disabling this behavior.

This was proposed in issue #282.

@smoyte

Copy link

Contributor Author

smoyte commented May 31, 2018 •

edited

Loading

Crap, will get those tests fixed and resubmit. Was working locally, hmm.

@smoyte smoyte force-pushed the no_reorder_with_parent_id_nil branch 2 times, most recently from 4d3f3e4 to 31c9e56 Compare

May 31, 2018 13:46

@smoyte

Copy link

Contributor Author

smoyte commented May 31, 2018 •

edited

Loading

Gosh, I'm having a real hard time replicating those two spec failures on my local machine. Here is what I tried (for the second one, on 2.3.6):

# Running with same settings as Travis:
rbenv install 2.3.6
rbenv local 2.3.6
export DB=postgresql
export BUNDLE_GEMFILE=$PWD/gemfiles/activerecord_5.2.gemfile
gem install bundler
bundle
bundle exec rake --trace spec:all
# Running one the failing specs a crap ton of times:
for run in {1..50}; do rspec spec/label_spec.rb:304; done
# Running the appropriate suite with the same random seed:
rspec --seed=29271

All the above produce nothing but green.

Any ideas?