-
-
Notifications
You must be signed in to change notification settings - Fork 798
Fix ParentRequires not working with EF Core projections #8749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PHILLIPS71
wants to merge
5
commits into
ChilliCream:main
from
PHILLIPS71:jp/parent-requires-ef-core-projection
Open
Fix ParentRequires not working with EF Core projections #8749
PHILLIPS71
wants to merge
5
commits into
ChilliCream:main
from
PHILLIPS71:jp/parent-requires-ef-core-projection
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
ParentRequiresfunctionality was not working when using EF Core projections. Required parent properties were not being included in the generated EF Core queries, causing computed properties to incorrectly resolvers if parent data wasn't also referenced in the query.Problem
The
ParentRequiresfeature worked correctly with the built-inSelectionExpressionBuilderbut failed when using EF Core projections throughUseProjection(). This happened because:SelectionExpressionBuilderprocesses field requirements and includes them in projectionsQueryableProjectionVisitor(used by EF Core projections) did not have any logic to handle field requirementsSolution
Added field requirements processing to
QueryableProjectionVisitorfollowing the same pattern asSelectionExpressionBuilderChanges Made
Core Implementation
QueryableProjectionVisitor.cs: added requirements processing logic following SelectionExpressionBuilder patternsTests
IntegrationTests.cs: added tests for both string-based and expression-based ParentRequires scenarios