-
Couldn't load subscription status.
- Fork 563
Patch for CVE-2019-10721 #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoops, good catch. I put in the wrong index. The last condition should
have been [1].
... On Sun, Apr 21, 2019, 02:26 David Jade ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In BlogEngine/BlogEngine.Core/Services/Security/Security.cs
<#205 (comment)>:
> @@ -204,6 +201,18 @@ public static bool AuthenticateUser(string username, string password, bool remem
return false;
}
+ private static bool IsLocalUrl(string url)
+ {
+ if (string.IsNullOrEmpty(url))
+ {
+ return false;
+ }
+ else
+ {
+ return ((url[0] == '/' && (url.Length == 1 || (url[1] != '/' && url[1] != '\\'))) || (url.Length > 1 && url[0] == '~' && url[0] == '/'));
There seems to be a condition here that can never be true - this part:
(url.Length > 1 && url[0] == '~' && url[0] == '/')
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#205 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABHJ7JOLJAG25ZMEYDGOILPRQQMTANCNFSM4HHKU53A>
.
Typo, will fix and resend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off:
https://docs.microsoft.com/en-us/aspnet/mvc/overview/security/preventing-open-redirection-attacks