Hi guilhermesuzuki,

this is great and I appreciate work you've done, but I can't merge this in one go.

The work-flow we should follow, specially if you want to update around 1,000 files on the project:

• Discuss feature you want to add/update. Do we need it, does it make sense in the core project, can it be done as add-on or extension instead and so on.
• Do a code review so I understand how this feature is implemented, so that I can maintain it later on.
• Would be nice to document this, although we suck in documenting and I'm first to admit
• If all is well, merge this feature in the code repository
• Repeat for next feature.

Right now, I have very basic understanding of these changes and, if in couple months down the road someone reports the bug, I'll be completely lost with these new code.

So you should either follow work-flow above or keep it as separate branch so people can use it if they need features you've added.

Hey rxtur!

I already created a branch morefeatures in my fork for those changes.
Well, if that becomes a branch in the official github repo I can help
supporting it.

On 09/17/2016 01:04 PM, rxtur wrote:

Hi guilhermesuzuki,

this is great and I appreciate work you've done, but I can't merge
this in one go.

The work-flow we should follow, specially if you want to update around
1,000 files on the project:

• Discuss feature you want to add/update. Do we need it, does it
  make sense in the core project, can it be done as add-on or
  extension instead and so on.
• Do a code review so I understand how this feature is implemented,
  so that I can maintain it later on.
• Would be nice to document this, although we suck in documenting
  and I'm first to admit
• If all is well, merge this feature in the code repository
• Repeat for next feature.

Right now, I have very basic understanding of these changes and, if in
couple months down the road someone reports the bug, I'll be
completely lost with these new code.

So you should either follow work-flow above or keep it as separate
branch so people can use it if they need features you've added.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#104 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0JRT-pVXaBD2HEU6SfkriJ1PrnlMz-ks5qrB2dgaJpZM4J_gG6.

Best Regards,

 Guilherme Suzuki @ Toronto, ON
 Senior .NET Developer
 http://guilherme.site/work/
 (647) 573 8173
 skype: suzuki.guilherme