Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

AFP updrates Flutter 3.29.0, removed iOS folder from example project, updated example project #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@TimHoogstrate
Copy link
Contributor

@TimHoogstrate TimHoogstrate commented Feb 19, 2025
edited
Loading

Removed iOS folder.
Updated gradle version for Android example project.
Updated Android package version to 1.1.0 (for Flutter 3.29.0 support)

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@TimHoogstrate TimHoogstrate changed the title (削除) removed ios from example folder (削除ここまで) (追記) AFP updrates Flutter 3.29.0 (追記ここまで) Feb 19, 2025
@TimHoogstrate TimHoogstrate changed the title (削除) AFP updrates Flutter 3.29.0 (削除ここまで) (追記) AFP updrates Flutter 3.29.0, removed iOS folder from example project (追記ここまで) Feb 19, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.65%. Comparing base (c4685dc) to head (d6ff736).
Report is 14 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 92.85% 89.65% -3.21% 
==========================================
 Files 1 1 
 Lines 28 29 +1 
==========================================
 Hits 26 26 
- Misses 2 3 +1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimHoogstrate TimHoogstrate changed the title (削除) AFP updrates Flutter 3.29.0, removed iOS folder from example project (削除ここまで) (追記) AFP updrates Flutter 3.29.0, removed iOS folder from example project, updated example project (追記ここまで) Feb 20, 2025
@TimHoogstrate TimHoogstrate marked this pull request as ready for review February 21, 2025 09:31
@TimHoogstrate TimHoogstrate merged commit ce464ab into Baseflow:main Feb 21, 2025
1 check passed
@TimHoogstrate TimHoogstrate deleted the 51-compile-flutter-3-29-afp-updates branch February 21, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /