backport: fix inappropriate connection reuse when using HTTP proxy if the initial CONNECT failed #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jasonjoo2010 wants to merge 1 commit into AsyncHttpClient:2.12.4 from jasonjoo2010:fix/back-port-http-proxy-connect-failure-2.12

Closed

backport: fix inappropriate connection reuse when using HTTP proxy if the initial CONNECT failed #2074

jasonjoo2010 wants to merge 1 commit into AsyncHttpClient:2.12.4 from jasonjoo2010:fix/back-port-http-proxy-connect-failure-2.12

Conversation

@jasonjoo2010

Copy link

Contributor

@jasonjoo2010 jasonjoo2010 commented Mar 10, 2025

It's a backport fix(#2072) for #2071 on 2.12.x

@jasonjoo2010 jasonjoo2010 changed the title ~~(削除) backport: fix inappropriate connection reuse when using HTTP proxy (削除ここまで)~~ (追記) backport: fix inappropriate connection reuse when using HTTP proxy if the initial CONNECT failed (追記ここまで)

Mar 10, 2025

@jasonjoo2010


 fix: inappropriate connection reuse when using HTTP proxy

There is an extra CONNECT request needs to send before the real request to the HTTP proxy and the 2nd request only happens if the CONNECT request succeeds. When CONNECT failed, the connection should be dropped as it's not in connected state.
Signed-off-by: Jason Joo <hblzxsj@gmail.com>