-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Enabled NullAway for oauth, proxy and resolver packages #1876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's break lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately breaking lines will break everything - I guess NullAway expects this XepOpt:NullAway:AnnotatedPackages parameter to be a single line without any breaks.
We can invert this parameter, i.e. instead of include only these packages we can have include all packages except the following. And I intend to eventually do that. But this requires fixing classes in the root org.asynchttpclient package first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's keep it then.
Let me know once ready to merge.
@Asapin Ping...
I'm currently working on enabling NullAway for the root org.asynchttpclient package, and there are quite a lot of changes (13 files at the moment), so maybe it's better to merge this PR as is?
No description provided.