-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Updated maven-javadoc-plugin to 3.0.1 #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch build was using outdated javadoc plugin which failed build on OracleJDK 8 due to javadoc generation error on `extras/retrofit2` module. Builds on OpenJDK 8 finished successfully. Changes: * maven-javadoc-plugin version bump to `3.0.1` * added javadoc generation to travis build recipe
OpenJDK 8:
~/dev/async-http-client (retrofit2_javadoc_issue)$ mvn --version
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018年10月24日T20:41:47+02:00)
Maven home: /home/bfg/software/maven
Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.18.0-15-generic", arch: "amd64", family: "unix"
~/dev/async-http-client (retrofit2_javadoc_issue)$ mvn clean package javadoc:javadoc -DskipTests=true
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22.862 s
[INFO] Finished at: 2019年02月28日T18:30:31+01:00
[INFO] ------------------------------------------------------------------------
Oracle JDK 8
~/dev/async-http-client (retrofit2_javadoc_issue)$ JAVA_HOME=/opt/java/jdk1.8.0_201 mvn --version
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018年10月24日T20:41:47+02:00)
Maven home: /home/bfg/software/maven
Java version: 1.8.0_201, vendor: Oracle Corporation, runtime: /opt/java/jdk1.8.0_201/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.18.0-15-generic", arch: "amd64", family: "unix"
~/dev/async-http-client (retrofit2_javadoc_issue)$ JAVA_HOME=/opt/java/jdk1.8.0_201 mvn clean package javadoc:javadoc -DskipTests=true
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22.744 s
[INFO] Finished at: 2019年02月28日T18:31:57+01:00
[INFO] ------------------------------------------------------------------------
@bfg AHC 2.8.1 is released. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch build was using outdated javadoc plugin which failed
build on OracleJDK 8 due to javadoc generation error on
extras/retrofit2module. Builds on OpenJDK 8 finished successfully.Changes:
3.0.1