-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Retrofit improvements #1615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrofit improvements #1615
Conversation
@bfg
bfg
commented
Feb 25, 2019
- bugfix: don't try to cancel already completed future, manifesting in bogus warning messages
- improvement: added ability to fetch http client instance from a supplier.
If AHC is used concurrently with rxjava retrofit call adapter using `flatMap(Function, maxConcurrency)` warning messages are being logged about future not being able to be cancelled, because it's already complete. This patch remedies situation by first checking whether future has been already completed.
Sometimes it's handy not to tie call factory to particular http client instance, but to fetch it from a supplier. This patch adds ability to fetch http client from a supplier while retaining ability to use particular, fixed http client instance.
Thanks!
Next time, could you please send 2 different PRs? :)
Will do; i was wondering whether i should open two PRs, but decided to go with two commits, because first one is so small. Thanks for accepting PR!
Hey, i've noticed that you've tagged 2.8.0 release with this PR included and i was really positively surprised by this. Thanks! However i don't see release on maven-central, nor 2.8.x snapshots in snapshot repo, is there a possibility that some publish task failed to complete successfully?
@bfg Deployments and indexation on maven central are asynchronous and there's typically a 20 min delay before the binary is actually deployed and several hours before it's indexed and visible on search.maven.org.
The binaries are already deployed: https://repo1.maven.org/maven2/org/asynchttpclient/async-http-client-project/2.8.0/
@slandelle thanks for clarification!