-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Code quality fix - Security - Array is stored directly #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code quality fix - Security - Array is stored directly #1039
Conversation
For everything that's on the hot path (meaning not tests and things like config that's only instanciated once), this one is a big "no way".
We definitely don't want the performance penalty of all those extra copies and allocations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not on hot path, why not.
Sorry, I'm going to reject this one. I mainly develop AHC because I use it for Gatling. Copying everything around like this would definitively kill performance.
Thanks anyway.
This pull request is focused on resolving occurrences of PMD rule pmd:ArrayIsStoredDirectly - "Security - Array is stored directly".
You can find more information about the issue here: http://pmd.sourceforge.net/pmd-4.3.0/rules/sunsecure.html
Please let me know if you have any questions.
Faisal.