-
Notifications
You must be signed in to change notification settings - Fork 1.6k
add a unit test to test reactive stream support for downloading files #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@slandelle Haven't forgot about this, but I'm a bit swamped. Hopefully, I'll be able to have a look at it tomorrow.
@dotta No worries. Just that I'm so swamped too that I definitively need you guys to help maintaining the reactive stream support :)
@slandelle No worries. I've pinged the rest of the Typesafe Play team to see if someone has time to look into this.
@slandelle
slandelle
force-pushed
the
master
branch
from
October 29, 2015 21:10
008f604 to
f36bec4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some test about reactive stream support in AHC and found a wield issue.
The test is to get a file from a http file server, in order to implement back pressure from the client to server, I used the StreamedAsyncHandler.
The issue is if the file I want to get is large (above 10K), it works fine.
But if the file is small (below 50 bytes), the onComplete of Subscriber got called, but the onNext never got called, and then get zero bytes from the server.
The unit test file is ReactiveStreamsDownLoadTest.java, it includes two tests, one is to download a large file, the other is to download a small file.
The HttpStaticFileServer code is copied from unit test in Netty.