-
Notifications
You must be signed in to change notification settings - Fork 50
chore(angular): v16 to v17 #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @AlexMiniApps, Do you have an Idea when you could merge this one?
Kindly regards
Hi @rbalet. I have to check how these changes reflect to the backward compatibility of the compiled lib. Unfortunately currently my schedule is too tight. But I will do it ASAP :)
Thx @AlexMiniApps .
FYI For the v17 there is no backwards compatibility lower than 16 as it is using signals to be more efficient.
But I think people can just use former version if they have former version of Angular ;)
Hey @AlexMiniApps, would you have time to do this one ?
(Maybe I've already said it) but I'd be glad to help you maintain the library in case you need it, as I'm using it.
Cheers
@rbalet Thanks for your efforts! As the v17 build doesn't have backward compatibility with v16 I'm not sure that this PR is acceptable unfortunately. But I promise you to do such checking :)
@AlexMiniApps KK, I'll continue to develop this library privately then.
Please text me once you could move forward as I have quite a few enhancement that I've already implemented
Hi @AlexMiniApps.
Would you ever have time to update this library ?
To know if I should publish a new library with my enhancement or just learn to be patient '^^.
Cheers
Hi @rbalet
As always thanks for the contribution! I hope I will have a time to support the lib. But primarily I will focus on backward compatibility and resolving of important issues.
@AlexMiniApps This commit does respect backward compatibility.
The change I made on my own repo though, does not from the angular v19, as Angular more to the standalone direction.
This will require a breaking change.
But once this get merged, I'll add new css variable features and some optimisation :)
@AlexMiniApps Just checking by if we could have any update on that topic
v17.0.0so that it follows angular's one (easier to see ;)