Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Webhooks] Code generation: update services and models #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdyenAutomationBot wants to merge 2 commits into main
base: main
Choose a base branch
Loading
from sdk-automation/Webhooks

Conversation

@AdyenAutomationBot
Copy link
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Aug 18, 2025
edited
Loading

OpenAPI spec files or templates have been modified on 22-10-2025 by commit.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the generated code for Adyen's webhook services and models. These changes are a direct result of recent modifications to the OpenAPI specification files. The primary purpose is to keep the client libraries synchronized with the latest API definitions, ensuring compatibility and access to new features or corrected behaviors. The updates include minor code formatting improvements in serializer classes and PHPDoc comment adjustments in model definitions.

Highlights

  • Automated Code Generation Update: This pull request contains automatically generated code updates for various webhook services and models, reflecting recent changes in the underlying OpenAPI specifications.
  • Code Formatting Standardization: Several ObjectSerializer.php files across different webhook modules have been updated to standardize code formatting, specifically adjusting whitespace in foreach loops and simplifying if statement syntax.
  • PHPDoc Comment Refinements: Minor adjustments were made to PHPDoc comments in CapabilitySettings.php to ensure consistent formatting of @param tags.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be an automated code generation task to update services and models based on new OpenAPI specifications. While the core changes are from a generator, several stylistic issues have been introduced across multiple files. These include violations of the PSR-12 coding standard, such as incorrect spacing in foreach loops and the use of single-line if statements without braces, which can harm readability and maintainability. Additionally, some PHPDoc comments now contain unnecessary trailing whitespace. My review focuses on these stylistic regressions to ensure the codebase remains clean and consistent.

}
} else {
foreach($data as $property => $value) {
foreach($data as $property => $value) {
Copy link

@gemini-code-assist gemini-code-assist bot Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This foreach statement is missing a space after the keyword. According to the PSR-12 coding standard, there must be one space after control structure keywords like foreach to ensure code consistency and readability. The previous version of the code was compliant with this rule.

 foreach ($data as $property => $value) {

if (!is_string($timestamp)) {
return $timestamp;
}
if (!is_string($timestamp)) return $timestamp;
Copy link

@gemini-code-assist gemini-code-assist bot Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change converts a multi-line if statement with braces to a single-line statement without them. The PSR-12 standard recommends always using braces for if statements to improve code clarity and prevent potential bugs when adding more lines to the block. The original code was more compliant with this standard.

 if (!is_string($timestamp)) {
 return $timestamp;
 }

}
} else {
foreach($data as $property => $value) {
foreach($data as $property => $value) {
Copy link

@gemini-code-assist gemini-code-assist bot Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This foreach statement is missing a space after the keyword. According to the PSR-12 coding standard, there must be one space after control structure keywords like foreach to ensure code consistency and readability. The previous version of the code was compliant with this rule.

 foreach ($data as $property => $value) {

if (!is_string($timestamp)) {
return $timestamp;
}
if (!is_string($timestamp)) return $timestamp;
Copy link

@gemini-code-assist gemini-code-assist bot Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change converts a multi-line if statement with braces to a single-line statement without them. The PSR-12 standard recommends always using braces for if statements to improve code clarity and prevent potential bugs when adding more lines to the block. The original code was more compliant with this standard.

 if (!is_string($timestamp)) {
 return $timestamp;
 }

* Sets amountPerIndustry
*
* @param array<string,\Adyen\Model\ConfigurationWebhooks\Amount>|null $amountPerIndustry
* @param array<string,\Adyen\Model\ConfigurationWebhooks\Amount>|null $amountPerIndustry
Copy link

@gemini-code-assist gemini-code-assist bot Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line has a trailing whitespace. While it doesn't affect functionality, it's best practice to remove it to maintain code cleanliness.

 * @param array<string,\Adyen\Model\ConfigurationWebhooks\Amount>|null $amountPerIndustry

if (!is_string($timestamp)) {
return $timestamp;
}
if (!is_string($timestamp)) return $timestamp;
Copy link

@gemini-code-assist gemini-code-assist bot Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change converts a multi-line if statement with braces to a single-line statement without them. The PSR-12 standard recommends always using braces for if statements to improve code clarity and prevent potential bugs when adding more lines to the block. The original code was more compliant with this standard.

 if (!is_string($timestamp)) {
 return $timestamp;
 }

}
} else {
foreach($data as $property => $value) {
foreach($data as $property => $value) {
Copy link

@gemini-code-assist gemini-code-assist bot Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This foreach statement is missing a space after the keyword. According to the PSR-12 coding standard, there must be one space after control structure keywords like foreach to ensure code consistency and readability. The previous version of the code was compliant with this rule.

 foreach ($data as $property => $value) {

if (!is_string($timestamp)) {
return $timestamp;
}
if (!is_string($timestamp)) return $timestamp;
Copy link

@gemini-code-assist gemini-code-assist bot Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change converts a multi-line if statement with braces to a single-line statement without them. The PSR-12 standard recommends always using braces for if statements to improve code clarity and prevent potential bugs when adding more lines to the block. The original code was more compliant with this standard.

 if (!is_string($timestamp)) {
 return $timestamp;
 }

}
} else {
foreach($data as $property => $value) {
foreach($data as $property => $value) {
Copy link

@gemini-code-assist gemini-code-assist bot Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This foreach statement is missing a space after the keyword. According to the PSR-12 coding standard, there must be one space after control structure keywords like foreach to ensure code consistency and readability. The previous version of the code was compliant with this rule.

 foreach ($data as $property => $value) {

if (!is_string($timestamp)) {
return $timestamp;
}
if (!is_string($timestamp)) return $timestamp;
Copy link

@gemini-code-assist gemini-code-assist bot Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change converts a multi-line if statement with braces to a single-line statement without them. The PSR-12 standard recommends always using braces for if statements to improve code clarity and prevent potential bugs when adding more lines to the block. The original code was more compliant with this standard.

 if (!is_string($timestamp)) {
 return $timestamp;
 }

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/Webhooks branch 5 times, most recently from c21182d to ff077a6 Compare August 25, 2025 11:09
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/Webhooks branch 3 times, most recently from f9c4b34 to ffcdb7c Compare August 29, 2025 16:29
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/Webhooks branch 9 times, most recently from 18b26ff to c1af3d5 Compare September 16, 2025 22:10
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/Webhooks branch 2 times, most recently from a01e300 to 0270d11 Compare September 23, 2025 11:17
Copy link

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/Webhooks branch 7 times, most recently from 3d3a6fa to 9a7809c Compare September 25, 2025 09:23
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/Webhooks branch 5 times, most recently from b4c9b2f to dea0da2 Compare September 26, 2025 12:18
Copy link

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/Webhooks branch 6 times, most recently from 305c01e to 055667d Compare October 7, 2025 07:42
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/Webhooks branch 9 times, most recently from 791e7b5 to 993ce6e Compare October 14, 2025 14:10
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/Webhooks branch 2 times, most recently from aeb6446 to 26d9497 Compare October 15, 2025 15:54
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /