Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Generate LEM, Transfers and BalancePlatform services and models #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcatanese merged 3 commits into main from generate-lem
Aug 13, 2025

Conversation

@gcatanese
Copy link
Contributor

@gcatanese gcatanese commented Aug 11, 2025
edited
Loading

Update services and models for BalancePlatform API

Update models for BalancePlatform for LEM and Transfers API

BalancePlatform API

  • Add new service AuthorizedCardUsersApi to manage (add, get, delete and update) authorized users to a given card
  • In PaymentInstrumentsApi add methods createNetworkTokenActivationData and getNetworkTokenActivationData to create and retrieve network token activation data for a payment instrument.
  • In AdditionalBankIdentification add new enums auBsbCode and caRoutingNumber
  • Added support for AdditionalbankIdentificationRequirement: auBsbCode, caRoutingNumber, gbSortCode or usRoutingNumber.

  • In Card add new attribute threeDSecure
  • Added usage field to Card and CardInfo to specify how many times the card can be used: singleUse or multiUse.
  • Added approvalExpired ReasonEnum to CreateSweepConfigurationV2, UpdateSweepConfigurationV2 and SweepConfigurationV2
  • Add NetworkTokenRequestor to NetworkToken
  • New walletProviderAccountScore and walletProviderDeviceScore attributes in TransactionRuleRestrictions
  • Added support USInternationalAchPriorityRequirement
  • Add walletProviderDeviceType in TransactionRuleRestrictions
  • Add enum INTEREST in TransferRoute.CategoryEnum

LEM API

  • In AdditionalBankIdentification add new enums auBsbCode and caRoutingNumber

Transfers API

  • In AdditionalBankIdentification add new enums auBsbCode and caRoutingNumber
  • Add attribute executionDate in Transfer, TransferData and TransferInfo
  • In IssuedCard add new attribute threeDSecure
  • Added email and url to PartyIdentification and UltimatePartyIdentification
  • In Transfer add new attribute createdAt, deprecate creationDate (use instead createdAt)
  • In TransferData add new attribute createdAt and updatedAt, deprecate creationDate (use instead createdAt)

Fix #755 #758

@gcatanese gcatanese self-assigned this Aug 11, 2025
@gcatanese gcatanese requested a review from a team as a code owner August 11, 2025 13:12
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating and expanding the Adyen PHP client library for the Balance Platform, Legal Entity Management (LEM), and Transfers APIs. My primary goal was to synchronize the client with the latest API specifications, introducing new functionalities and improving existing model definitions. This includes adding support for new bank identification types, enhancing card and network token management, and refining transaction rule capabilities. Additionally, I've made several minor documentation and code style adjustments to improve clarity and consistency across the codebase.

Highlights

  • Expanded Bank Identification Support: I've updated the AdditionalBankIdentification models across Balance Platform, Legal Entity Management, and Transfers APIs to support Australian BSB codes (auBsbCode) and Canadian routing numbers (caRoutingNumber). This expands the types of bank accounts that can be identified and processed.
  • New Network Token Models: New models like NetworkTokenActivationDataRequest, NetworkTokenActivationDataResponse, and NetworkTokenRequestor have been introduced in the Balance Platform API. These additions facilitate the management and provisioning of network tokens for card-related operations.
  • Card Usage Specification: The Card and CardInfo models in the Balance Platform API now include a usage property, allowing for the specification of whether a card is singleUse or multiUse. This provides more granular control over card functionality.
  • Enhanced Transaction Rule Restrictions: I've added a new WalletProviderDeviceType model and integrated it into TransactionRuleRestrictions in the Balance Platform API. This enables the creation of transaction rules based on the type of device used by a wallet provider.
  • Transfer Routing and Scheduling Enhancements: The TransferRoute model in the Balance Platform API now includes a CATEGORY_INTEREST constant, and the documentation for instant transfer priorities has been clarified to include transfers within the United States. A new ExecutionDate model has also been added to the Transfers API for scheduling transfers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates and generates a large number of models for the BalancePlatform, Legal Entity Management, and Transfers APIs. The changes primarily consist of adding new models, updating existing ones with new properties and enum values, fixing documentation and links, and applying stylistic improvements to use statements. One potential issue was identified regarding inconsistent handling of nullable enum properties in the generated code, which could lead to runtime errors.

@gcatanese gcatanese changed the title (削除) Generate LEM, Transfers and BalancePlatforms services and models (削除ここまで) (追記) Generate LEM, Transfers and BalancePlatform services and models (追記ここまで) Aug 11, 2025
Copy link

@gcatanese gcatanese merged commit d7ce9b2 into main Aug 13, 2025
9 checks passed
@gcatanese gcatanese deleted the generate-lem branch August 13, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid value 'auBsbCode' for 'type', must be one of 'gbSortCode', 'usRoutingNumber'

1 participant

AltStyle によって変換されたページ (->オリジナル) /