-
Notifications
You must be signed in to change notification settings - Fork 114
Generate LEM, Transfers and BalancePlatform services and models #804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gemini-code-assist
gemini-code-assist
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @gcatanese, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating and expanding the Adyen PHP client library for the Balance Platform, Legal Entity Management (LEM), and Transfers APIs. My primary goal was to synchronize the client with the latest API specifications, introducing new functionalities and improving existing model definitions. This includes adding support for new bank identification types, enhancing card and network token management, and refining transaction rule capabilities. Additionally, I've made several minor documentation and code style adjustments to improve clarity and consistency across the codebase.
Highlights
- Expanded Bank Identification Support: I've updated the
AdditionalBankIdentificationmodels across Balance Platform, Legal Entity Management, and Transfers APIs to support Australian BSB codes (auBsbCode) and Canadian routing numbers (caRoutingNumber). This expands the types of bank accounts that can be identified and processed. - New Network Token Models: New models like
NetworkTokenActivationDataRequest,NetworkTokenActivationDataResponse, andNetworkTokenRequestorhave been introduced in the Balance Platform API. These additions facilitate the management and provisioning of network tokens for card-related operations. - Card Usage Specification: The
CardandCardInfomodels in the Balance Platform API now include ausageproperty, allowing for the specification of whether a card issingleUseormultiUse. This provides more granular control over card functionality. - Enhanced Transaction Rule Restrictions: I've added a new
WalletProviderDeviceTypemodel and integrated it intoTransactionRuleRestrictionsin the Balance Platform API. This enables the creation of transaction rules based on the type of device used by a wallet provider. - Transfer Routing and Scheduling Enhancements: The
TransferRoutemodel in the Balance Platform API now includes aCATEGORY_INTERESTconstant, and the documentation forinstanttransfer priorities has been clarified to include transfers within the United States. A newExecutionDatemodel has also been added to the Transfers API for scheduling transfers.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
@gemini-code-assist
gemini-code-assist
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates and generates a large number of models for the BalancePlatform, Legal Entity Management, and Transfers APIs. The changes primarily consist of adding new models, updating existing ones with new properties and enum values, fixing documentation and links, and applying stylistic improvements to use statements. One potential issue was identified regarding inconsistent handling of nullable enum properties in the generated code, which could lead to runtime errors.
3ffc5da to
625d749
Compare
Quality Gate Passed Quality Gate passed
Issues
27 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
74.1% Duplication on New Code
Uh oh!
There was an error while loading. Please reload this page.
Update services and models for BalancePlatform API
Update models for BalancePlatform for LEM and Transfers API
BalancePlatform API
AuthorizedCardUsersApito manage (add, get, delete and update) authorized users to a given cardPaymentInstrumentsApiadd methodscreateNetworkTokenActivationDataandgetNetworkTokenActivationDatato create and retrieve network token activation data for a payment instrument.AdditionalBankIdentificationadd new enumsauBsbCodeandcaRoutingNumberAdditionalbankIdentificationRequirement:auBsbCode,caRoutingNumber,gbSortCodeorusRoutingNumber.Cardadd new attributethreeDSecureusagefield toCardandCardInfoto specify how many times the card can be used:singleUseormultiUse.approvalExpiredReasonEnum toCreateSweepConfigurationV2,UpdateSweepConfigurationV2andSweepConfigurationV2NetworkTokenRequestortoNetworkTokenwalletProviderAccountScoreandwalletProviderDeviceScoreattributes inTransactionRuleRestrictionsUSInternationalAchPriorityRequirementwalletProviderDeviceTypeinTransactionRuleRestrictionsINTERESTinTransferRoute.CategoryEnumLEM API
AdditionalBankIdentificationadd new enumsauBsbCodeandcaRoutingNumberTransfers API
AdditionalBankIdentificationadd new enumsauBsbCodeandcaRoutingNumberexecutionDateinTransfer,TransferDataandTransferInfoIssuedCardadd new attributethreeDSecureemailandurltoPartyIdentificationandUltimatePartyIdentificationTransferadd new attributecreatedAt, deprecatecreationDate(use insteadcreatedAt)TransferDataadd new attributecreatedAtandupdatedAt, deprecatecreationDate(use insteadcreatedAt)Fix #755 #758